Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host header removed from default HTTP repo connector allowed headers #40

Closed
malaskowski opened this issue Feb 27, 2019 · 2 comments
Closed

Host header removed from default HTTP repo connector allowed headers #40

malaskowski opened this issue Feb 27, 2019 · 2 comments
Assignees
@marcinkp
Labels
bug Something isn't working

Comments

@malaskowski
Copy link
Member

malaskowski commented Feb 27, 2019 •
edited
Loading

Describe the bug
In #39 Host header was removed from allowedRequestHeaders because of failing integration tests.

Investigate and bring back Host header to default values of allowedRequestHeaders again.

To Reproduce
Steps to reproduce the behavior:

  1. Add Host to allowedRequestHeaders in httpRepoConnectorHandler.conf
  2. Run the tests
  3. See failed tests

Expected behavior
Tests pass with Host header.
@malaskowski malaskowski added the bug Something isn't working label Feb 27, 2019
@marcinkp marcinkp self-assigned this Jul 3, 2019
@dragarthPl
Copy link

@Skejven Is this issue is still valid ?

I see "Host" value in allowedRequestHeaders in httpRepoConnectorHandler.conf file.

@malaskowski
Copy link
Member Author

Looks like this is fixed, tests have Host in the:
https://github.com/Knotx/knotx-stack/blame/master/src/functionalTest/resources/conf/routes/handlers/httpRepoConnectorHandler.conf

Looks that it was fixed in #54 , thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcinkp marcinkp

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marcinkp @malaskowski @dragarthPl