-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Knot.x 2.0 Stack & Unit tests #39
Knot.x 2.0 Stack & Unit tests #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, here is a thought:
I know that we moved http repo connector to be a handler. Doing that Knot.x still supports the setup, where multiple repositories configuration is needed. In Knot.x 1.X it was possible due to defining new module in modules
and assigning separate configuration to each http repo instance. Now it is possible because each route has its own repository and separate configuration for http handler. Maybe there should be an example or integration test for that case?
Another concern is that knots have now hardcoded addresses. I don't currently have the case when it might be required to run more than one instance of modules other than http repo, but maybe we should spend few more minutes on that. WDYT?
knotx-it-tests/src/test/resources/conf/routes/handlers/assemblerHandler.conf
Outdated
Show resolved
Hide resolved
…nitialization to server.conf
Knot.x Stack update to Knot.x 2.0 modules.
Description
Knot.x Stack update to Knot.x 2.0 modules.
Types of changes
Checklist:
I hereby agree to the terms of the Knot.x Contributor License Agreement.