Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knot.x 2.0 Stack & Unit tests #39

Merged
merged 9 commits into from
Feb 27, 2019

Conversation

tomaszmichalak
Copy link
Member

@tomaszmichalak tomaszmichalak commented Feb 19, 2019

Knot.x Stack update to Knot.x 2.0 modules.

Description

Knot.x Stack update to Knot.x 2.0 modules.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

@tomaszmichalak tomaszmichalak changed the base branch from master to project/knotx-2 February 19, 2019 14:29
Copy link
Member

@malaskowski malaskowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, here is a thought:
I know that we moved http repo connector to be a handler. Doing that Knot.x still supports the setup, where multiple repositories configuration is needed. In Knot.x 1.X it was possible due to defining new module in modules and assigning separate configuration to each http repo instance. Now it is possible because each route has its own repository and separate configuration for http handler. Maybe there should be an example or integration test for that case?

Another concern is that knots have now hardcoded addresses. I don't currently have the case when it might be required to run more than one instance of modules other than http repo, but maybe we should spend few more minutes on that. WDYT?

@tomaszmichalak tomaszmichalak changed the title Feature/refactor core modules Knot.x 2.0 Stack & Unit tests Feb 27, 2019
@tomaszmichalak tomaszmichalak merged commit e498436 into project/knotx-2 Feb 27, 2019
@tomaszmichalak tomaszmichalak deleted the feature/refactor-core-modules branch February 27, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants