Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded knot addresses #2

Closed
malaskowski opened this issue Feb 27, 2019 · 1 comment
Closed

Hardcoded knot addresses #2

malaskowski opened this issue Feb 27, 2019 · 1 comment
Labels
discussion New enhancement proposition, awaits broader discussion or design session.

Comments

@malaskowski
Copy link
Member

Originally moved from Knotx/knotx-stack#39 (review)
I know that we moved http repo connector to be a handler. Doing that Knot.x still supports the setup, where multiple repositories configuration is needed. In Knot.x 1.X it was possible due to defining new module in modules and assigning separate configuration to each http repo instance. Now it is possible because each route has its own repository and separate configuration for http handler. Maybe there should be an example or integration test for that case?

Another concern is that knots have now hardcoded addresses. I don't currently have the case when it might be required to run more than one instance of modules other than http repo, but maybe we should spend few more minutes on that. WDYT?

@malaskowski malaskowski added the discussion New enhancement proposition, awaits broader discussion or design session. label Feb 27, 2019
@tomaszmichalak
Copy link
Member

This is fixed with #3 .

marcinkp pushed a commit that referenced this issue Jul 8, 2019
marcinkp pushed a commit that referenced this issue Jul 18, 2019
marcinkp pushed a commit that referenced this issue Jul 18, 2019
marcinkp pushed a commit that referenced this issue Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion New enhancement proposition, awaits broader discussion or design session.
Projects
None yet
Development

No branches or pull requests

2 participants