You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Originally moved from Knotx/knotx-stack#39 (review)
I know that we moved http repo connector to be a handler. Doing that Knot.x still supports the setup, where multiple repositories configuration is needed. In Knot.x 1.X it was possible due to defining new module in modules and assigning separate configuration to each http repo instance. Now it is possible because each route has its own repository and separate configuration for http handler. Maybe there should be an example or integration test for that case?
Another concern is that knots have now hardcoded addresses. I don't currently have the case when it might be required to run more than one instance of modules other than http repo, but maybe we should spend few more minutes on that. WDYT?
The text was updated successfully, but these errors were encountered:
Originally moved from Knotx/knotx-stack#39 (review)
I know that we moved http repo connector to be a handler. Doing that Knot.x still supports the setup, where multiple repositories configuration is needed. In Knot.x 1.X it was possible due to defining new module in
modules
and assigning separate configuration to each http repo instance. Now it is possible because each route has its own repository and separate configuration for http handler. Maybe there should be an example or integration test for that case?Another concern is that knots have now hardcoded addresses. I don't currently have the case when it might be required to run more than one instance of modules other than http repo, but maybe we should spend few more minutes on that. WDYT?
The text was updated successfully, but these errors were encountered: