Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knotx/knotx-fragments#79 Expose task log. #72

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

tomaszmichalak
Copy link
Member

@tomaszmichalak tomaszmichalak commented Jan 21, 2020

Configuration changes & functional tests. It relates to PR - knotx/knotx-fragments#88.

Upgrade notes (if appropriate)

It adds commented consumers configuration:

#consumerFactories = [
#  {
#    factory = fragmentHtmlBodyWriter
#    config {
#      condition {
#        param = debug
#      }
#      fragmentTypes = [ "snippet" ]
#    }
#  }
#]

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

@tomaszmichalak tomaszmichalak force-pushed the feature/#79-expose-task-log branch from 43be9b1 to 8356877 Compare January 21, 2020 14:44
@tomaszmichalak tomaszmichalak merged commit 1187172 into master Jan 21, 2020
@tomaszmichalak tomaszmichalak deleted the feature/#79-expose-task-log branch February 15, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants