Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed example project and replace with integrationTests #411

Merged
merged 3 commits into from
Apr 16, 2018
Merged

Removed example project and replace with integrationTests #411

merged 3 commits into from
Apr 16, 2018

Conversation

marcinczeczko
Copy link
Contributor

Description

Remove example project from core - replace it with integration tests

Motivation and Context

  • core should be core, example project is to be created in Knotx organization

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

malaskowski
malaskowski approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@malaskowski malaskowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@marcinczeczko marcinczeczko merged commit 65eb4bc into milestone/backpressure-and-configs Apr 16, 2018
@marcinczeczko marcinczeczko deleted the feature/example-into-it-tests branch April 16, 2018 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malaskowski malaskowski malaskowski approved these changes

@tomaszmichalak tomaszmichalak tomaszmichalak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backpressure and Configuration [1.3.0]
Development

Successfully merging this pull request may close these issues.
3 participants
@marcinczeczko @tomaszmichalak @malaskowski