Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed header matching to be case insensitive #415

Merged

Conversation

marcinczeczko
Copy link
Contributor

Description

The allowedRequestHeaders configurations that were using regexp to express which ones to allow where case sensitive. However, since the headers in HTTP are case insensitive we need to handle it the same way

Motivation and Context

Make header matching case insensitive

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

@marcinczeczko marcinczeczko merged commit c2a0f13 into milestone/backpressure-and-configs Apr 20, 2018
@marcinczeczko marcinczeczko deleted the bugfix/headers-case-sensitive branch April 20, 2018 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants