Response code logging tweaks - different log levels for success, redi… #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malaskowski
approved these changes
Jul 2, 2018
|
Thank you @scypio for this fix. |
marcinczeczko
suggested changes
Jul 2, 2018
| @@ -144,12 +145,21 @@ private String encode(String value) { | |||
| } | |||
|
|
|||
| private ClientResponse toResponse(Buffer buffer, final HttpClientResponse httpResponse) { | |||
| if (httpResponse.statusCode() >= 300 && httpResponse.statusCode() < 400) { //redirect responses | |||
| LOGGER.info("Repository 3xx response: {}, Headers[{}]", httpResponse.statusCode(), | |||
| if (HttpStatusClass.SUCCESS.contains(httpResponse.statusCode())) { | |||
There was a problem hiding this comment.
For a better readability of each condition, get the .statusCode() into variable and do the check against that variable
HTTP status code logging tweaks - PR changes
Http status logging tweaks - typo fixed
|
Would it be possible to add information about requested resource while logging response? |
|
What do you think about adding request path (especially in warn and error level) in the message? |
|
@Skejven @mateuszgrab-cognifide I added request URL logging for 4xx, 5xx response codes |
marcinczeczko
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rect and error responses
Currently every response from repository that return HTTP status code different than 200 is logged using ERROR logger level. The strategy has been adjusted.
Description
2xx - success - log at debug
3xx - redirect - log at info
4xx - client error - log at warn
5xx - server error - log at error
other - log at warn
#423
Motivation and Context
Too many error messages may trigger unwanted warnings for devops. Error log level should indicate that something is wrong.
Screenshots (if appropriate):
Types of changes
Checklist:
I hereby agree to the terms of the Knot.x Contributor License Agreement.