Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to knotx template engine #473

Merged
merged 3 commits into from
Dec 3, 2018
Merged

Switch to knotx template engine #473

merged 3 commits into from
Dec 3, 2018

Conversation

malaskowski
Copy link
Member

Description

Mark Handlebars Knot as deprecated on behalf of Knot.x Template Engine.

Motivation and Context

HBS Knot is outdated implementation, it will be replaced by dedicated module Knot.x Template Engine and removed in the future.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

@tomaszmichalak tomaszmichalak merged commit 8188eee into master Dec 3, 2018
@tomaszmichalak tomaszmichalak deleted the feature/switch-to-knotx-template-engine branch December 3, 2018 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszmichalak tomaszmichalak tomaszmichalak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malaskowski @tomaszmichalak