refactor(phpstan): use Broker instead with MethodCall and Scope

To get ride of: ------ ------------------------------------------------------------------------------------------------------------------------------------------------- Line TranslatableInheritanceTest.php ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 30 Call to an undefined method Knp\DoctrineBehaviors\Tests\Fixtures\Entity\Translatable\AbstractTranslatableEntityTranslation::setExtendedTitle(). 33 Call to an undefined method Knp\DoctrineBehaviors\Tests\Fixtures\Entity\Translatable\AbstractTranslatableEntityTranslation::setExtendedTitle(). 36 Call to an undefined method Knp\DoctrineBehaviors\Tests\Fixtures\Entity\Translatable\AbstractTranslatableEntityTranslation::setExtendedTitle(). 50 Call to an undefined method Knp\DoctrineBehaviors\Tests\Fixtures\Entity\Translatable\AbstractTranslatableEntityTranslation::getExtendedTitle(). 53 Call to an undefined method Knp\DoctrineBehaviors\Tests\Fixtures\Entity\Translatable\AbstractTranslatableEntityTranslation::getExtendedTitle(). 56 Call to an undefined method Knp\DoctrineBehaviors\Tests\Fixtures\Entity\Translatable\AbstractTranslatableEntityTranslation::getExtendedTitle(). ------ ------------------------------------------------------------------------------------------------------------------------------------------------- `$entity` was seen as an AbstractTranslatableEntity and not as an ExtendedTranslatableEntity :(
KnpLabs · Feb 12, 2020 · 636254d · 636254d
1 parent 87d8849
commit 636254d
Show file tree

Hide file tree

Showing 4 changed files with 55 additions and 14 deletions.
diff --git a/src/PHPStan/Type/Helper.php b/src/PHPStan/Type/Helper.php
@@ -2,23 +2,34 @@
 
 namespace Knp\DoctrineBehaviors\PHPStan\Type;
 
+use PhpParser\Node\Expr\MethodCall;
+use PHPStan\Analyser\Scope;
+use PHPStan\Broker\Broker;
 use PHPStan\Reflection\MethodReflection;
 
 final class Helper
 {
-    public static function getTranslationClassFromMethodReflection(MethodReflection $methodReflection): string
+    public static function getTranslationClass(Broker $broker, MethodCall $methodCall, Scope $scope): string
     {
-        $translatableReflection       = $methodReflection->getDeclaringClass();
-        $translatableNativeReflection = $translatableReflection->getNativeReflection();
+        $type              = $scope->getType($methodCall->var);
+        $translatableClass = $type->getReferencedClasses()[0];
 
-        return $translatableNativeReflection->getMethod('getTranslationEntityClass')->invoke(null);
+        return $broker
+            ->getClass($translatableClass)
+            ->getNativeReflection()
+            ->getMethod('getTranslationEntityClass')
+            ->invoke(null);
     }
 
-    public static function getTranslatableClassFromMethodReflection(MethodReflection $methodReflection): string
+    public static function getTranslatableClass(Broker $broker, MethodCall $methodCall, Scope $scope): string
     {
-        $translationReflection       = $methodReflection->getDeclaringClass();
-        $translationNativeReflection = $translationReflection->getNativeReflection();
+        $type              = $scope->getType($methodCall->var);
+        $translatableClass = $type->getReferencedClasses()[0];
 
-        return $translationNativeReflection->getMethod('getTranslatableEntityClass')->invoke(null);
+        return $broker
+            ->getClass($translatableClass)
+            ->getNativeReflection()
+            ->getMethod('getTranslatableEntityClass')
+            ->invoke(null);
     }
 }
diff --git a/src/PHPStan/Type/TranslatableGetTranslationsDynamicMethodReturnTypeExtension.php b/src/PHPStan/Type/TranslatableGetTranslationsDynamicMethodReturnTypeExtension.php
@@ -8,15 +8,25 @@
 use Knp\DoctrineBehaviors\Contract\Entity\TranslatableInterface;
 use PhpParser\Node\Expr\MethodCall;
 use PHPStan\Analyser\Scope;
+use PHPStan\Broker\Broker;
+use PHPStan\Reflection\BrokerAwareExtension;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Type\DynamicMethodReturnTypeExtension;
 use PHPStan\Type\IterableType;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\TypeCombinator;
 
-final class TranslatableGetTranslationsDynamicMethodReturnTypeExtension implements DynamicMethodReturnTypeExtension
+final class TranslatableGetTranslationsDynamicMethodReturnTypeExtension implements DynamicMethodReturnTypeExtension, BrokerAwareExtension
 {
+    /** @var Broker */
+    private $broker;
+
+    public function setBroker(Broker $broker): void
+    {
+        $this->broker = $broker;
+    }
+
     public function getClass(): string
     {
         return TranslatableInterface::class;
@@ -29,7 +39,7 @@ public function isMethodSupported(MethodReflection $methodReflection): bool
 
     public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): \PHPStan\Type\Type
     {
-        $translationClass = Helper::getTranslationClassFromMethodReflection($methodReflection);
+        $translationClass = Helper::getTranslationClass($this->broker, $methodCall, $scope);
 
         return TypeCombinator::intersect(
             new ObjectType(Collection::class),

diff --git a/src/PHPStan/Type/TranslatableTranslateDynamicMethodReturnTypeExtension.php b/src/PHPStan/Type/TranslatableTranslateDynamicMethodReturnTypeExtension.php
@@ -7,12 +7,22 @@
 use Knp\DoctrineBehaviors\Contract\Entity\TranslatableInterface;
 use PhpParser\Node\Expr\MethodCall;
 use PHPStan\Analyser\Scope;
+use PHPStan\Broker\Broker;
+use PHPStan\Reflection\BrokerAwareExtension;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Type\DynamicMethodReturnTypeExtension;
 use PHPStan\Type\ObjectType;
 
-final class TranslatableTranslateDynamicMethodReturnTypeExtension implements DynamicMethodReturnTypeExtension
+final class TranslatableTranslateDynamicMethodReturnTypeExtension implements DynamicMethodReturnTypeExtension, BrokerAwareExtension
 {
+    /** @var Broker */
+    private $broker;
+
+    public function setBroker(Broker $broker): void
+    {
+        $this->broker = $broker;
+    }
+
     public function getClass(): string
     {
         return TranslatableInterface::class;
@@ -25,7 +35,7 @@ public function isMethodSupported(MethodReflection $methodReflection): bool
 
     public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): \PHPStan\Type\Type
     {
-        $translationClass = Helper::getTranslationClassFromMethodReflection($methodReflection);
+        $translationClass = Helper::getTranslationClass($this->broker, $methodCall, $scope);
 
         return new ObjectType($translationClass);
     }

diff --git a/src/PHPStan/Type/TranslationGetTranslatableDynamicMethodReturnTypeExtension.php b/src/PHPStan/Type/TranslationGetTranslatableDynamicMethodReturnTypeExtension.php
@@ -7,12 +7,22 @@
 use Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface;
 use PhpParser\Node\Expr\MethodCall;
 use PHPStan\Analyser\Scope;
+use PHPStan\Broker\Broker;
+use PHPStan\Reflection\BrokerAwareExtension;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Type\DynamicMethodReturnTypeExtension;
 use PHPStan\Type\ObjectType;
 
-final class TranslationGetTranslatableDynamicMethodReturnTypeExtension implements DynamicMethodReturnTypeExtension
+final class TranslationGetTranslatableDynamicMethodReturnTypeExtension implements DynamicMethodReturnTypeExtension, BrokerAwareExtension
 {
+    /** @var Broker */
+    private $broker;
+
+    public function setBroker(Broker $broker): void
+    {
+        $this->broker = $broker;
+    }
+
     public function getClass(): string
     {
         return TranslationInterface::class;
@@ -25,7 +35,7 @@ public function isMethodSupported(MethodReflection $methodReflection): bool
 
     public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): \PHPStan\Type\Type
     {
-        $translatableClass = Helper::getTranslatableClassFromMethodReflection($methodReflection);
+        $translatableClass = Helper::getTranslatableClass($this->broker, $methodCall, $scope);
 
         return new ObjectType($translatableClass);
     }