Sluggable and accents

[CharlyPoppins]

Hello,

sluggable is not handling accents. Is that normal or did I miss something in the settings ?

[CharlyPoppins]

There is a problem with iconv.
$sluggableText = "Châteauneuf du Pape"; $usableValues = iconv('UTF-8', 'ASCII//TRANSLIT', $sluggableText); echo $usableValues; // Ch?teauneuf du Pape

[CharlyPoppins]

Saw this on https://php.net/manual/fr/function.iconv.php

Please note that iconv('UTF-8', 'ASCII//TRANSLIT', ...) doesn't work properly when locale category LC_CTYPE is set to C or POSIX. You must choose another locale otherwise all non-ASCII characters will be replaced with question marks. This is at least true with glibc 2.5.

Example:

https://github.com/KnpLabs/DoctrineBehaviors/blob/master/src/Model/Sluggable/SluggableMethods.php
So I set setlocale(LC_CTYPE, "fr_FR"); in public function generateSlug() { ... }

Is that the right thing to do ?

[docteurklein]

Unfortunatly, I never had to run into those problems, and I have no idea how transliteration works :)

[markitosgv]

accents like áéóèàñß not been converted i think is possible to modify generateSlug function with this

public function generateSlug()
{
    if ( $this->getRegenerateSlugOnUpdate() || empty( $this->slug ) ) {
        $fields = $this->getSluggableFields();
        $usableValues = [];

        foreach ($fields as $field) {
            // Too bad empty is a language construct...otherwise we could use the return value in a write context :)
            $val = $this->{$field};
            if ( !empty( $val ) ) {
                $usableValues[] = $val;
            }
        }

        if ( count($usableValues) < 1 ) {
            throw new \UnexpectedValueException('Sluggable expects to have at least one usable (non-empty) field from the following: [ ' . implode($fields, ',') .' ]');
        }

        // generate the slug itself
        $sluggableText = implode($usableValues, ' ');
        $sluggableText = strtr(utf8_decode($sluggableText), utf8_decode('ŠŒŽšœžŸ¥µÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝßàáâãäåæçèéêëìíîïðñòóôõöøùúûüýÿ'),
            'SOZsozYYuAAAAAAACEEEEIIIIDNOOOOOOUUUUYsaaaaaaaceeeeiiiionoooooouuuuyy');
        $urlized = strtolower( trim( preg_replace("/[^a-zA-Z0-9\/_|+ -]/", '', iconv('UTF-8', 'ASCII//TRANSLIT', $sluggableText) ), $this->getSlugDelimiter() ) );
        $urlized = preg_replace("/[\/_|+ -]+/", $this->getSlugDelimiter(), $urlized);

        $this->slug = $urlized;
    }
}

What do you think about insert this conversion?

$sluggableText = strtr(utf8_decode($sluggableText), utf8_decode('ŠŒŽšœžŸ¥µÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝßàáâãäåæçèéêëìíîïðñòóôõöøùúûüýÿ'),
            'SOZsozYYuAAAAAAACEEEEIIIIDNOOOOOOUUUUYsaaaaaaaceeeeiiiionoooooouuuuyy');

Words like 'Café', 'Niño', 'ße' become 'cafe', 'nino', 'be'

[kuczek]

@markitosgv It does not supports polish characters ążśźęćńół ĄŻŚŹĘĆŃÓŁ

[kuczek]

And look at #162 it solve that problem.

[MAXakaWIZARD]

@CharlyPoppins I've added your examples as test cases in #162

[CharlyPoppins]

Thanks, not used to git yet. So that means I need to wait an "admin" to merge your pull request #162 and then I can do a composer update of that git : "knplabs/doctrine-behaviors": "dev-master".
Am I right ?

[MAXakaWIZARD]

@CharlyPoppins exactly

[CharlyPoppins]

Ok perfect :) Thanks again