Slug generation from cyrillic strings #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe slug generator should be separate service, which you will be able to define? Right now it's hard to use this slug function in your project, and it's hard to override it if you need solution not provided by default. Some interface and basic implementations in project, and possiblity of easy extension for special uses. |
|
@kuczek I see your point. I'll implement this. |
|
Implemented custom slug generators via generateSlugValue method override |
|
@docteurklein Any news on when this could be merged? |
|
In your opinion, the slug from cyrillic, doesn't should be did using the official transliteration chars? |
Closed
|
@docteurklein please review this |
MAXakaWIZARD
force-pushed
the
pr-sluggable-for-cyrillic-strings
branch
from
6c20c86 to
93d5215
Compare
docteurklein
added a commit
that referenced
this pull request
Mar 2, 2015
…trings Slug generation from cyrillic strings
This was referenced Jul 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace iconv usage with behat/transliterator, add some test cases.
Slug generation from cyrillic string now works.