Extract slug generator to separate method #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added rules for russian transliteration
| */ | ||
| protected function getTransliterator() | ||
| { | ||
| return function($string) { |
There was a problem hiding this comment.
This look kinda weird. Inception function in a method.
If you need to pass parameter, try call_user_func_array
Also it would be nice to keep inner compatibility of this package. Checkout this localeCallable in Translatable.
There was a problem hiding this comment.
I agree that you don't need to return a closure to call it directly after.
Just name the method "transliterate" (or someting) and return this result.
Anyone will be able to replace it in its class anyway. See what I mean?
Otherwise, (and it was the case before already with iconv), but we need to put ext-intl (or ext-iconv) in the list of requires (or suggests) in composer.json IMHO.
akovalyov
force-pushed
the
master
branch
4 times, most recently
from
6cb1e53 to
0a444f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason for changing this is that all standard php methods of transliaterationg are unstable (like iconv) or unusable for russian (Transliterator class). So that I managed to extract slug generation to separate method which can be redefined without need to copypaste.
In addition, I created Utils class with static function which applies traditional russian way of transliteration.