Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to prevent default translation search #115

Merged
merged 1 commit into from
Oct 21, 2014

Conversation

DerekRoth
Copy link
Contributor

Fixes #107

@docteurklein
Copy link
Contributor

does this PR has to be merged before #107 ?

@chandon
Copy link

chandon commented Jun 10, 2014

i'm not sure this is enough to solve the problem, as the #107 test will still be in a failure state, because you've to force the option to False to avoid the problem (as the default value is set to True). If your merge both this one and #107, Travis CI will still fail

@DerekRoth
Copy link
Contributor Author

Sure, but the point of the default value to true is to avoid a bc break.
This is a simple fix but if we want to avoid having to add this option and
still fix the bug i think that a real design change is required. The
translate method should return a proxy instead of a translation object.
Le 10 juin 2014 15:19, "chandon" notifications@github.com a écrit :

i'm not sure this is enough to solve the problem, as the #107
#107 test will still
be in a failure state, because you've to force the option to False to avoid
the problem (as the default value is set to True). If your merge both this
one and #107 #107,
Travis CI will still fail


Reply to this email directly or view it on GitHub
#115 (comment)
.

@chandon
Copy link

chandon commented Jun 12, 2014

@DerekRoth I agree with you, a real design change is needed. I did a compatibility break for myself, so i'll not pull it

@docteurklein
Copy link
Contributor

feel free to break things, i'm not against bumping the version at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants