-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename listener to subscriber #134
Conversation
They do not take forever to install.
That would indeed be a BC break for those who manually defined services for them (or extended them, which shouldn't be done actually). One solution would be to provide a temporary set of classes (that extends subscriber) and named like before. their ctor would raise a |
@docteurklein : I was more thinking about people using the DIC to inject services defined in your file, but after a closer look, I can see that you marked them as private, so there is no problem. Regarding the name of the classes, I don't think it is a BC-break : these classes are not part of your public API (which you could tag), they are used internally to do things. That's not like if we renamed the traits. I think you can merge this safely. |
right, lets merge it and note the renamings the UPGRADE.md file. |
could you add a UPGRADE.md file ? |
@docteurklein : with a 1.0.1 to 1.0.2 § ? I'll add it, but not now, because I think the private services could and should be renamed first, do you agree ? Plus, I'm a bit busy right now. |
right we can add it later |
rename listener to subscriber
Ok, I'll try to do it tomorrow if I can. |
This PR renames listener classes to
SomethingSubscriber
. There are still some "listener" occurences in the README and in the DIC file, but I think changing them would be a BC-break.