Fix: isEmpty() return true if it's empty #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 7, 2016 12:05
Fixed: isEmpty() return always false
cursedcoder
suggested changes
Oct 11, 2016
| @@ -93,6 +93,13 @@ public function getLocale() | |||
| */ | |||
| public function isEmpty() | |||
| { | |||
| return false; | |||
| foreach (get_object_vars($this) as $var => $value) { | |||
| if (in_array($var, array('id', 'translatable', 'locale'))) | |||
There was a problem hiding this comment.
please use short syntax array
| continue; | ||
|
|
||
| if (!empty($value)) | ||
| return false; |
There was a problem hiding this comment.
please use enclosing brackets {}
| if (!empty($value)) | ||
| return false; | ||
| } | ||
| return true; |
There was a problem hiding this comment.
return statement should be separated by 1 space line
added 4 commits
October 11, 2016 18:21
added 4 commits
October 12, 2016 10:06
isempty(): Fix code according to PSR or symfony codestyles
|
LGTM 👍 /cc @cursedcoder |
cursedcoder
approved these changes
Oct 12, 2016
|
this method is meant to be overriden. we just provide a dummy impl as sensible defaults. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function isEmpty() return always false... fix it