Only set locales on entities managed by knp translations #392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where you could have a entity with the setCurrentLocale method, but that is not a translatable entity managed by KNP.
This PR only sets the default and current locales on entities that are translatable instead of relying on a method existance.
Closes #314
Closes #315
It also fixes compatibility with Sylius, because it uses its own translations implementation, and it is incompatible with having this other bundle installed.