Add PHPStan extensions, for Translatable/Translation interfaces #520

Kocal · 2020-02-12T21:01:35Z

This PR is a proposal for #516, and aim to replace #517.

Before: at b8a4b01 with 69 errors:

➜  DoctrineBehaviors git:(d) vendor/bin/phpstan analyze
Note: Using configuration file /home/kocal/Dev/DoctrineBehaviors/phpstan.neon.
 95/95 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ----------------------------------------------------------------------------------------------------- 
  Line   tests/ORM/SluggableWithTranslatableEntityAndUniquenessTest.php                                       
 ------ ----------------------------------------------------------------------------------------------------- 
  29     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().  
  30     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().  
  47     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().  
  48     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getSlug().   
  49     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().  
  50     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getSlug().   
  56     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().  
  57     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().  
  66     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getSlug().   
  67     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getSlug().   
  68     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().  
  69     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().  
  71     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getSlug().   
  72     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getSlug().   
 ------ ----------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------- 
  Line   tests/ORM/TranslatableInheritanceTest.php                                                                    
 ------ ------------------------------------------------------------------------------------------------------------- 
  29     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().          
  30     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setExtendedTitle().  
  32     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().          
  33     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setExtendedTitle().  
  35     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().          
  36     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setExtendedTitle().  
  49     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().          
  50     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getExtendedTitle().  
  52     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().          
  53     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getExtendedTitle().  
  55     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().          
  56     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getExtendedTitle().  
 ------ ------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/ORM/TranslatableTest.php                                                                                                  
 ------ -------------------------------------------------------------------------------------------------------------------------------- 
  33     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  34     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  35     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  47     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().                             
  48     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().                             
  49     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().                             
  55     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  56     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  57     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  69     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().                             
  70     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().                             
  71     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().                             
  77     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  78     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  90     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().                             
  91     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().                             
  93     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  94     Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  104    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().                             
  105    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().                             
  106    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().                             
  121    Call to an undefined method Knp\DoctrineBehaviors\Tests\Fixtures\Entity\TranslatableEntity::setTitle().                         
  134    Call to an undefined method Knp\DoctrineBehaviors\Tests\Fixtures\Entity\TranslatableEntity::getTitle().                         
  135    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().                             
  141    Call to an undefined method Knp\DoctrineBehaviors\Tests\Fixtures\Entity\TranslatableEntity::setTitle().                         
  154    Call to an undefined method Knp\DoctrineBehaviors\Tests\Fixtures\Entity\TranslatableEntity::getTitle().                         
  156    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().                             
  157    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().                             
  177    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  178    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  179    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  181    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().                             
  188    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  189    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  199    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::getTitle().                             
  207    Parameter #1 $translations of method Knp\DoctrineBehaviors\Tests\Fixtures\Entity\TranslatableEntity::setTranslations() expects  
         Doctrine\Common\Collections\Collection&iterable<Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface>, array<int,         
         Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface> given.                                                              
  215    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  216    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  217    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  239    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  240    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  241    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
  247    Call to an undefined method Knp\DoctrineBehaviors\Contract\Entity\TranslationInterface::setTitle().                             
 ------ -------------------------------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 69 errors                                                                                                
                                                                                                                        

💡 Tip of the Day:
One or more properties in your code do not have a phpDoc with a type
but it could be inferred from the constructor to find more bugs.
Use inferPrivatePropertyTypeFromConstructor: true in your phpstan.neon to try it out!

Now: at last commit, with 0 errors

➜  DoctrineBehaviors git:(phpstan-extension) ✗ vendor/bin/phpstan analyze
Note: Using configuration file /home/kocal/Dev/DoctrineBehaviors/phpstan.neon.
 99/99 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


                                                                                                                        
 [OK] No errors                                                                                                         
                                                                                                                        

💡 Tip of the Day:
One or more properties in your code do not have a phpDoc with a type
but it could be inferred from the constructor to find more bugs.
Use inferPrivatePropertyTypeFromConstructor: true in your phpstan.neon to try it out!

phpstan.neon

To get ride of: ------ ------------------------------------------------------------------------------------------------------------------------------------------------- Line TranslatableInheritanceTest.php ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 30 Call to an undefined method Knp\DoctrineBehaviors\Tests\Fixtures\Entity\Translatable\AbstractTranslatableEntityTranslation::setExtendedTitle(). 33 Call to an undefined method Knp\DoctrineBehaviors\Tests\Fixtures\Entity\Translatable\AbstractTranslatableEntityTranslation::setExtendedTitle(). 36 Call to an undefined method Knp\DoctrineBehaviors\Tests\Fixtures\Entity\Translatable\AbstractTranslatableEntityTranslation::setExtendedTitle(). 50 Call to an undefined method Knp\DoctrineBehaviors\Tests\Fixtures\Entity\Translatable\AbstractTranslatableEntityTranslation::getExtendedTitle(). 53 Call to an undefined method Knp\DoctrineBehaviors\Tests\Fixtures\Entity\Translatable\AbstractTranslatableEntityTranslation::getExtendedTitle(). 56 Call to an undefined method Knp\DoctrineBehaviors\Tests\Fixtures\Entity\Translatable\AbstractTranslatableEntityTranslation::getExtendedTitle(). ------ ------------------------------------------------------------------------------------------------------------------------------------------------- `$entity` was seen as an AbstractTranslatableEntity and not as an ExtendedTranslatableEntity :(

TomasVotruba · 2020-02-19T13:54:41Z

Great job! Thank you

TomasVotruba · 2020-03-24T18:34:43Z

Could you look at #537 ?
Bug caused by this

Kocal · 2020-03-24T19:46:36Z

Should be fixed by #537

phpstan: clean "ignore_errors" for Translatable/Translation

b8a4b01

Kocal commented Feb 12, 2020

View reviewed changes

phpstan.neon Show resolved Hide resolved

Kocal added 6 commits February 12, 2020 23:19

test: use good type

65e561c

fix: use @phpstan-param for a more precise type on setTranslations

3013bec

phpstan: add extensions

a5052aa

chore: code style

df19a87

test: add @method annotations on proxy translatable

16a9c4e

Kocal force-pushed the phpstan-extension branch from 3fa7a87 to 16a9c4e Compare February 12, 2020 22:20

Kocal marked this pull request as ready for review February 12, 2020 22:23

chore: wording

5c81b70

Kocal requested a review from TomasVotruba February 19, 2020 13:49

TomasVotruba merged commit 3810047 into KnpLabs:master Feb 19, 2020

Kocal deleted the phpstan-extension branch February 19, 2020 14:08

TomasVotruba mentioned this pull request May 1, 2020

Adding generics support #516

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PHPStan extensions, for Translatable/Translation interfaces #520

Add PHPStan extensions, for Translatable/Translation interfaces #520

Kocal commented Feb 12, 2020 •

edited

Loading

TomasVotruba commented Feb 19, 2020

TomasVotruba commented Mar 24, 2020

Kocal commented Mar 24, 2020

Add PHPStan extensions, for Translatable/Translation interfaces #520

Add PHPStan extensions, for Translatable/Translation interfaces #520

Conversation

Kocal commented Feb 12, 2020 • edited Loading

TomasVotruba commented Feb 19, 2020

TomasVotruba commented Mar 24, 2020

Kocal commented Mar 24, 2020

Kocal commented Feb 12, 2020 •

edited

Loading