-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SF62 / SF63 deprecations (doctrine subscriber deprecated) #738
base: master
Are you sure you want to change the base?
Conversation
Is there any plans to merge this PR? The code looks good and it would prevent an issue with Symfony 7 in november ! If there's anything to do to help let me know |
@SimonVanacco Hello, while waiting for the integration of PR for the fixes of deprecations on PHP 8.2 and SF6.3 you can try to reference my repository. Let me know if all is fine:
|
Thanks, @raziel057, the deprecation errors were filling the logs and making it difficult to see the important errors. BTW, here's a CLI way of using your fork. composer config repositories.doctrine_behaviors '{"type": "vcs", "url": "https://github.com/raziel057/DoctrineBehaviors"}'
composer req knplabs/doctrine-behaviors:dev-master |
I tested a bit and had zero issues so far - and the deprecations were indeed gone ! Nice work ! |
@TomasVotruba could you please review and merge this PR? |
Gentle bump |
Hi, any news? |
Fix deprecation raised when using
doctrine/doctrine-bundle
starting from v2.10 (see doctrine/DoctrineBundle@656beec).On my test suite (~400 tests) the deprecation is raised 7497x:
The test suite have been run locally after the change and I could fix :
Fix first part of #737