support for curl timeout parameter #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I change as well the format of the response in case of exception to run the tests |
|
|
||
| $this->createConfiguration('full'); | ||
|
|
||
| $this->assertEquals(8, $this->configuration->getParameter('knp_disqus.curl_timeout')); |
There was a problem hiding this comment.
8 is actually equal to Disqus::DEFAULT_TIMEOUT, so it's not the best value to test with
|
@jlaso are you still interested in this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow slow connections (for instance in my vagrant development) is not enough with the 5 seconds of Buzz/Curl timeout default.