-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ancestorClass option consistency to underscore #351
Open
shakaran
wants to merge
24
commits into
KnpLabs:master
Choose a base branch
from
shakaran:ancestor_class_underscore
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
ff8864b
Make ancestorClass option consistency to underscore
shakaran 4fc676d
Require symfony/deprecation-contracts for trigger warnings
shakaran df85637
Add deprecation contracts and allow both ways for support BC
shakaran d2b325b
Fix if spaced as per review suggested
shakaran d7a3399
Revert changes in doc for deprecated way as per review suggested
shakaran 3aeb687
Update version number for deprecation
shakaran 24fa9c2
Improve warning message for twig deprecation as per review suggested
shakaran 4103108
Merge branch 'master' into ancestor_class_underscore
shakaran 05e3231
Update test for show as legacy deprecation warnings
shakaran 5bf59b9
Avoid duplication of configs and show deprecations warnings too
shakaran 5ae265b
Update php version in composer
shakaran 10569aa
Try to avoid replacements by deprecation contracts in github build
shakaran abdeda8
Try another sed vudu way
shakaran ae50e57
Add exclusion pattern /pattern/!s/pattern/
shakaran 98046aa
Update the sed vudu charm
shakaran 4ef0026
Vudu sed require a space
shakaran d82c70f
Update build.yaml
garak 4abbba4
Add support deprecation for knp_menu_render and knp_menu_get with anc…
shakaran 9c5797c
Use ExpectDeprecationTrait for deprecation message
shakaran 78608e3
Add @group Legacy or Legacy in name for allow pass test in CI
shakaran 742aacc
Mistake preprend at beginning legacy
shakaran 9de5229
Add as annotation since CI don't recognize
shakaran c42343b
Remove message since expects empty message for trait
shakaran a4bc394
Add empty string message for deprecation instead null
shakaran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need a space between
!
ands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you added it before the wrong
s
...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this was giving me a headache. Thanks for the charm.
Ready to merge?