charset as first argument in ListRenderer #120
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK this DI configuration is wrong. It shows an error in SonataMediaBundle when you try to edit a media.
The problem is that the Renderer class constructor (parent of ListRenderer) is
so, giving this DIC configuration you got array() as charset. And it throws an error like:
The only thing I don't know is where the %knp_menu.renderer.list.options% parameter should be injected. But at least removing it solves the problem. Is this parameter still needed?
Regards.