feature #880 Make invalid request error more clear (acrobat)

This PR was merged into the 2.15.x-dev branch. Discussion ---------- Closes #879 and closes #760 Commits ------- f84efb4 Make invalid request error more clear
KnpLabs · Jun 13, 2020 · 0ce1f09 · 0ce1f09
2 parents d557dc4 + f84efb4
commit 0ce1f09
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/Github/HttpClient/Plugin/GithubExceptionThrower.php b/lib/Github/HttpClient/Plugin/GithubExceptionThrower.php
@@ -48,7 +48,7 @@ public function doHandleRequest(RequestInterface $request, callable $next, calla
  $content = ResponseMediator::getContent($response);
  if (is_array($content) && isset($content['message'])) {
  if (400 === $response->getStatusCode()) {
- throw new ErrorException($content['message'], 400);
+ throw new ErrorException(sprintf('%s (%s)', $content['message'], $response->getReasonPhrase()), 400);
  }
 
  if (422 === $response->getStatusCode() && isset($content['errors'])) {

diff --git a/test/Github/Tests/HttpClient/Plugin/GithubExceptionThrowerTest.php b/test/Github/Tests/HttpClient/Plugin/GithubExceptionThrowerTest.php
@@ -92,11 +92,11 @@ public static function responseProvider()
  ],
  json_encode(
  [
- 'message' => 'Bad Request',
+ 'message' => 'Problems parsing JSON',
  ]
  )
  ),
- 'exception' => new \Github\Exception\ErrorException('Bad Request', 400),
+ 'exception' => new \Github\Exception\ErrorException('Problems parsing JSON (Bad Request)', 400),
  ],
  '422 Unprocessable Entity' => [
  'response' => new Response(