Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] split HTML ouput misses the final message in chat #114

Closed
code-consensus opened this issue Sep 4, 2024 · 3 comments
Closed

[BUG] split HTML ouput misses the final message in chat #114

code-consensus opened this issue Sep 4, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@code-consensus
Copy link

  • WhatsApp version: 2.24.06.77
  • OS: Android
  • Platform: Windows
  • Branch and version: 0.10.0

Describe the bug
With the "--split" command-line option, the program splits up larger chats. In ALL the generated chats, including ones that are NOT split up, the final message is missing.

To Reproduce
Steps to reproduce the behavior:

  1. run wtsexporter without "--split"
  2. open an HTML chat file and scroll down to see the final message (either from "You" or the contact).
  3. run wtsexporter with "--split"
  4. open the very same chat in the new output folder. Scroll down to see the final message and you will see the last message is not there. This affects ALL output files, not just the ones that were split up.

The issue is in create_html() under the "if maximum_size is not None" section, but I can't seem to figure out what the problem is.

@KnugiHK KnugiHK self-assigned this Sep 7, 2024
@KnugiHK KnugiHK added the bug Something isn't working label Sep 7, 2024
@KnugiHK
Copy link
Owner

KnugiHK commented Sep 7, 2024

The issue should be fixed in e268484. You can try the dev branch to see if the problem persists or if other problems come out.

@code-consensus
Copy link
Author

I tested this, and it seems to work perfectly now -- thanks! I tested with, and without, the --split option, and for non-split files, their hashes were identical. And on the the split files, from the chats that I at least recognized, seems to also work.

The issue should be fixed in e268484. You can try the dev branch to see if the problem persists or if other problems come out.

@KnugiHK KnugiHK added the pending for release Feature or bug fix to be released label Sep 9, 2024
@KnugiHK
Copy link
Owner

KnugiHK commented Oct 24, 2024

Released in 0.10.5.

@KnugiHK KnugiHK closed this as completed Oct 24, 2024
@KnugiHK KnugiHK removed the pending for release Feature or bug fix to be released label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants