Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Support for WhatsApp Business (iPhone only) #60

Merged
merged 12 commits into from
Sep 22, 2023
Merged

Feat: Support for WhatsApp Business (iPhone only) #60

merged 12 commits into from
Sep 22, 2023

Conversation

andres-pcg
Copy link
Contributor

No description provided.

@andres-pcg
Copy link
Contributor Author

Hello there, @KnugiHK!

I've come across a truly fascinating project—kudos to you! Recently, I encountered a situation where I needed to create a local backup of my WhatsApp business account. Upon exploring the project, I discovered that it didn't quite support this functionality out of the box. However, I took the initiative to tweak a few elements, and voilà, it's now functioning seamlessly.

Feeling quite satisfied with the results, I've decided to take things a step further and collaborate with you on this. I've already initiated a pull request. If there are any suggestions or adjustments you'd like me to implement, please don't hesitate to share. I'm more than willing to lend a hand and make this project even better. Looking forward to working together!

@andres-pcg andres-pcg changed the title feat(whatsApp_business): support for SMB feat(whatsApp_business): support for SMB (iPhone only) Aug 15, 2023
@andres-pcg
Copy link
Contributor Author

Btw, I don't have myself an Android device so I didn't even attempt to implement this for Android. I might need a little help there.

@KnugiHK KnugiHK self-requested a review August 15, 2023 05:15
@KnugiHK KnugiHK added the enhancement New feature or request label Aug 15, 2023
@KnugiHK KnugiHK linked an issue Aug 15, 2023 that may be closed by this pull request
Can this work in Whatsapp Business ? #10
Open
KnugiHK
KnugiHK requested changes Aug 15, 2023
View reviewed changes
Copy link
Owner

@KnugiHK KnugiHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit to vcard could break Android's vcard output. I will fix it and consolidate the changes.

Whatsapp_Chat_Exporter/__main__.py Show resolved Hide resolved
KnugiHK
KnugiHK requested changes Aug 15, 2023
View reviewed changes
Copy link
Owner

@KnugiHK KnugiHK left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One outstanding problem for encrypted iOS backup. See the comment below.

Whatsapp_Chat_Exporter/extract_iphone_media.py Outdated Show resolved Hide resolved
@KnugiHK
Copy link
Owner

KnugiHK commented Aug 15, 2023 •
edited
Loading

Although the PR does not work for encrypted backup, unencrypted backup should be fine.

I refactored the code a bit. Try again to see if it works for WhatsApp Business in iOS.

PS. I also changed the option from --smb to --business for a more straightforward presentation.

@KnugiHK KnugiHK changed the title feat(whatsApp_business): support for SMB (iPhone only) Feat: Support for WhatsApp Business (iPhone only) Aug 15, 2023
@andres-pcg
Copy link
Contributor Author

@KnugiHK Loved the way you implemented identifiers. It's a lot cleaner and easier to maintain that way 🙌

@andres-pcg
Copy link
Contributor Author

@KnugiHK it did work as expected 🚀. However, there's a weird WhatsApp message that I hadn't seen before:
Screenshot 2023-09-11 at 6 30 32 PM

@KnugiHK
Copy link
Owner

KnugiHK commented Sep 16, 2023

@KnugiHK it did work as expected 🚀. However, there's a weird WhatsApp message that I hadn't seen before:

Can you check what that message is in WhatsApp?

@andres-pcg
Copy link
Contributor Author

andres-pcg commented Sep 16, 2023 •
edited
Loading

@KnugiHK it did work as expected 🚀. However, there's a weird WhatsApp message that I hadn't seen before:

Can you check what that message is in WhatsApp?

Those are old messages that seems to have corrupted when I migrated from android version of WB with a third party application long time ago. New messages (generated on the iPhone) are intact and showing correctly.

@KnugiHK
Copy link
Owner

KnugiHK commented Sep 16, 2023

@KnugiHK it did work as expected 🚀. However, there's a weird WhatsApp message that I hadn't seen before:

Can you check what that message is in WhatsApp?

Those are old messages that seems to have corrupted when I migrated from android version of WB with a third party application long time ago. New messages (generated on the iPhone) are intact and showing correctly.

Shall we consider it as not related to this PR?

@andres-pcg
Copy link
Contributor Author

@KnugiHK it did work as expected 🚀. However, there's a weird WhatsApp message that I hadn't seen before:

Can you check what that message is in WhatsApp?

Those are old messages that seems to have corrupted when I migrated from android version of WB with a third party application long time ago. New messages (generated on the iPhone) are intact and showing correctly.

Shall we consider it as not related to this PR?

Not at all. That's a corner case that's outside of this module scope.

@KnugiHK
Copy link
Owner

KnugiHK commented Sep 17, 2023

Great. Will merge it soon.

@KnugiHK KnugiHK merged commit 5aad65f into KnugiHK:dev Sep 22, 2023
@KnugiHK
Copy link
Owner

KnugiHK commented Sep 22, 2023

Thanks for your contribution!

KnugiHK
KnugiHK reviewed Sep 22, 2023
View reviewed changes
Copy link
Owner

@KnugiHK KnugiHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andres-pcg
Copy link
Contributor Author

Thanks for your contribution!

You are welcome. My pleasure.

Thank you for the follow up and the initiative of creating this project. Good luck!

@KnugiHK
Copy link
Owner

KnugiHK commented Nov 12, 2023

Released in 0.9.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnugiHK KnugiHK KnugiHK requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can this work in Whatsapp Business ?
2 participants
@andres-pcg @KnugiHK