pgo/env: Account for .exe extensions during path resolution #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently cargo-pgo does not work out of the box on Windows, because llvm-tools-preview binaries have .exe extensions. This commit extends find_pgo_env to look up llvm-profdata with .exe extension in case one without it is not available.
|
Hi, thanks for the PR! As you have probably noticed, I haven't really tested this crate outside of Linux, so there are probably more demons lurking here. I'm not even sure if BOLT is supported on Windows or whether it works there at all, I'll try to check it later, for now this seems like an easy fix to make PGO working on Windows. Thanks! |
|
I added basic Windows CI tests (#4), so hopefully in the future such things will be easier to detect (at least for PGO, BOLT is currently not tested on CI). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently cargo-pgo does not work out of the box on Windows, because
llvm-tools-preview binaries have .exe extensions. This commit extends
find_pgo_env to look up llvm-profdata with .exe extension in case one
without it is not available.
I have verified manually that renaming
llvm-profdata.exetollvm-profdatamanually works with currentmain.bolt/envprobably has the same issue on Windows, but I didn't look into that. Should we tackle BOLT in this PR as well?By the way, thanks for this library - it looks very neat!