Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect RUSTFLAGS set in .cargo/config.toml #50

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

Kobzol
Copy link
Owner

@Kobzol Kobzol commented Mar 4, 2024

This PR changes the way cargo-pgo sets RUSTFLAGS in order to not overwrite flags set in .cargo/config.toml file(s). It doesn't handle ENCODED_RUSTFLAGS, but hopefully this should resolve most of the use-cases of setting custom RUSTFLAGS.

Fixes: #49

Now rustflags in `.cargo/config.toml` won't be overridden.
@Kobzol Kobzol merged commit 0f5583b into main Mar 28, 2024
5 checks passed
@Kobzol Kobzol deleted the append-to-rustflags branch March 28, 2024 14:36
@Kobzol Kobzol restored the append-to-rustflags branch March 28, 2024 14:38
@Kobzol Kobzol deleted the append-to-rustflags branch March 28, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo-pgo ignores all rustflags defined in config.toml file, how to pass custom rustflags to pgo build?
1 participant