Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid retrying failed tasks #238

Closed
martinzugnoni opened this issue May 11, 2017 · 2 comments
Closed

Avoid retrying failed tasks #238

martinzugnoni opened this issue May 11, 2017 · 2 comments

Comments

@martinzugnoni
Copy link

Apparently the default behaviour for failed task is to queue a new task a retry it after certain time.

Is there any way to avoid retrying failed tasks? I mean, if a task raised an error for some reason, do not queue it again, and just display it in the list of "Failed tasks".

It happened to me that a task kept failing for a long time and it was queued again and again.

Thanks!
@martinzugnoni
Copy link
Author

It's related to this issue: #194
But instead of limiting the amount of retries, avoiding them completely.

Balletie added a commit to Balletie/django-q that referenced this issue Mar 9, 2018
@Balletie
Add option for acknowledging failed tasks (globally and per-task)
03abbc9 
If a task fails with an exception, it is retried until it
succeeds. This is contrary to what is said in the documentation: under
the "Architecture" section, heading "Broker" it says that even when a
task errors, it's still considered a successful delivery. Failed tasks
never get acknowledged however, thereby being retried after the
timeout period. See also issues Koed00#238 and Koed00#194.

This patch adds an option to acknowledge failures, thereby closing
issue Koed00#238. Issue Koed00#194 would require some more work. The default of
this option is set to `False`, thereby maintaining backwards
compatibility.
@Balletie Balletie mentioned this issue Mar 9, 2018
Merged
@Eagllus
Copy link
Collaborator

Eagllus commented Apr 9, 2018 •
edited
Loading

Closing this issue as requested in the pr

@Eagllus Eagllus closed this as completed Apr 9, 2018
@gorkemyontem gorkemyontem mentioned this issue Jan 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Eagllus @martinzugnoni