Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to qinfo to print task IDs #173

Merged
merged 2 commits into from
Apr 5, 2017
Merged

Add option to qinfo to print task IDs #173

merged 2 commits into from
Apr 5, 2017

Conversation

UplandsDynamic
Copy link

Adding the option to qinfo to print IDs (PIDs) of running clusters provides an easy way for scripts and process managers to fetch their PID(s).

Option to print IDs (PIDs) of running clusters added to qinfo.
This provides an easy way for scripts and process managers to fetch the PID(s) of running clusters.
@codecov-io
Copy link

codecov-io commented Jun 3, 2016

Current coverage is 90.59%

Merging #173 into master will decrease coverage by 6.02%

  1. 3 files (not in diff) in django_q/brokers were modified. more
    • Misses +82
    • Hits -82
  2. 1 files (not in diff) in django_q were modified. more
    • Misses +76
    • Hits -76
@@             master       #173   diff @@
==========================================
  Files            40         40          
  Lines          2725       2734     +9   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           2633       2477   -156   
- Misses           92        257   +165   
  Partials          0          0          

Powered by Codecov. Last updated by 2e062a2...d66209d

@Koed00
Copy link
Owner

Koed00 commented Jun 7, 2016

I like the idea , it's simple enough.
Unfortunately I just deprecated optparse for argparse, to be compatible with Django 1.9 and 1.10.
Do you mind changing that?

I'll add a test when you're done.

@UplandsDynamic
Copy link
Author

Thanks! I added this option as a convenient way to reference the PIDs of running clusters from the management scripts I've written to run django_q as a service on FreeBSD. The scripts create a pid file when a cluster starts, then use the --ids option to easily check for running clusters when stopping/restarting the service. Works like a charm.

I've committed the change from optparse to argparse.

@UplandsDynamic
Copy link
Author

Is this still on track to be merged for inclusion in the next release?
Thanks.

@Koed00
Copy link
Owner

Koed00 commented Jul 25, 2016

Sure. Thanks for reminding me. I'll merge it to master when I can.
The release itself will have to wait till the weekend.

@Koed00 Koed00 merged commit 427bb5b into Koed00:master Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants