Guard loop sleep made configurable #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 90.80%@@ master #182 diff @@
==========================================
Files 40 40
Lines 2726 2729 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 2634 2478 -156
- Misses 92 251 +159
Partials 0 0
|
|
Like it. Only problem I see is with the schedules when a value greater than 60 seconds is used. |
|
Awesome. I'll merge it as soon as I fix the postgres problems with the current tests. |
|
Sorry, I just noticed that counter in Cluster::guard was 30, not 60. Should guard_cycle be in range (0, 30)? Should the counter be configurable as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, consider making guard loop sleep configurable. For ORM broker, it may be useful to increase the cycle to avoid too often modifications of DB.