Feature reconnect on error #223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the broker is not usable the guard loop can enter a infinite loop where it tries to save the status every 0.5 seconds. This change forces the broker connection to reset for those that support it.
django_redis may use a custom client such as django-redis-sentinel which has different internals that need to be terminated properly.
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 93.19% 90.75% -2.44%
==========================================
Files 40 40
Lines 2717 2768 +51
==========================================
- Hits 2532 2512 -20
- Misses 185 256 +71
Continue to review full report at Codecov.
|
P-EB
pushed a commit
to P-EB/django-q
that referenced
this pull request
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were reorganising our clone and this forced the pull request to close.
This is the same feature branch as #207