Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for guard/monitor in multi-cluster setup #248

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

bob-r
Copy link

@bob-r bob-r commented Jul 10, 2017

modified file: cluster.py

scheduler function (guard process): fix for #231, alternative solution to 87b87ff for MySQL

save_task function (monitor process): fix for #225

@codecov-io
Copy link

codecov-io commented Jul 11, 2017

Codecov Report

Merging #248 into master will increase coverage by 0.3%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #248     +/-   ##
=========================================
+ Coverage   89.88%   90.18%   +0.3%     
=========================================
  Files          44       42      -2     
  Lines        2866     2762    -104     
=========================================
- Hits         2576     2491     -85     
+ Misses        290      271     -19
Impacted Files Coverage Δ
django_q/cluster.py 90.44% <72.72%> (-0.77%) ⬇️
django_q/conf.py 70.9% <0%> (-0.52%) ⬇️
django_q/tests/test_scheduler.py 100% <0%> (ø) ⬆️
django_q/tests/settings.py 100% <0%> (ø) ⬆️
django_q/brokers/aws_sqs.py 0% <0%> (ø) ⬆️
django_q/tests/test_cluster.py 100% <0%> (ø) ⬆️
django_q/tests/test_cached.py 100% <0%> (ø) ⬆️
django_q/core_signing.py
django_q/queues.py
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2040771...e018744. Read the comment docs.

@aleehedl
Copy link

aleehedl commented Mar 5, 2020

As the SAVE_LIMIT doesn't seem to be respected in a multi-cluster environment, I would like to see this one merged. The commits in this PR obviously need some cleanup (probably 2 commits is enough).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants