-
-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 2 compatiblity #279
Conversation
fix usage of iter_entry_points
Codecov Report
@@ Coverage Diff @@
## django_2_compat #279 +/- ##
==================================================
Coverage ? 90.25%
==================================================
Files ? 44
Lines ? 2832
Branches ? 0
==================================================
Hits ? 2556
Misses ? 276
Partials ? 0
Continue to review full report at Codecov.
|
Yeah, quite a lot of the tests are failing on Django 2.0, even though they ran fine in the alpha and beta stages. I wish I had more time for it, but I just started a new job and I need to move by the end of the month. |
@Koed00 no worries I have time to figure this out! |
ps: Enjoy your new job 😉 |
Closed it by mistake and it din't want me to open it but now it does XD |
In Django 1.10 MIDDLEWARE_CLASSES is set to deprecated and is removed in Django 2.0. The SessionAuthenticationMiddleware is also removed from Django 2.0 and was already unconditionally enabled in Django 1.10.
This will not fix anything related to Django 2.0 but will allow MAC users to run Django-Q allowing tests to be run locally.
@Koed00 I'm kind of stuck here. I found a way to fix the remaining problems (there all related to one thing) I added a commit showing the 'old' core.signing features working, hope you have time this weekend and that that it will save you some time. |
By reverting django.core.signing to Django 1.11.8 version Django-Q works This is not designed as a 'good' solution just to show where I think the problem is.
@Koed00 any update about the problem my pr was/is experiencing? |
I've not had time to look into this yet. Just moved all my belongings into storage and found a temporary apartment. Making this a priority for the weekend. I need it to work reliably with Django 2 for a new project as well. Thanks for all the work you put in Ronald. Best wishes for the new year! |
@Koed00 no problem at all 😄 |
This is not a new branch I just merged master to see if that fixes most of the Django 2.0 problems.
And I was unable to run the tests local so decided to create a PR.
that just checks if master + django_2_compat is 👍!Edit 1: Well
master
+django_2_compat
din't solve all problems.Edit 2: Fixed a few of the bugs so far.