Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SQS to use environment variables #283

Merged

Conversation

svdgraaf
Copy link
Contributor

@svdgraaf svdgraaf commented Jan 9, 2018

If no credentials are set, boto3 will look them up in the environment variables, boto3 config or aws config by default. This PR makes the credentials in the config optional, so boto3 can check the other locations if needed.

@codecov-io
Copy link

codecov-io commented Jan 9, 2018

Codecov Report

Merging #283 into master will decrease coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
- Coverage   90.25%   90.12%   -0.13%     
==========================================
  Files          44       44              
  Lines        2831     2835       +4     
==========================================
  Hits         2555     2555              
- Misses        276      280       +4
Impacted Files Coverage Δ
django_q/brokers/aws_sqs.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e225466...17ea1e7. Read the comment docs.

@Koed00 Koed00 merged commit c8599fe into Koed00:master Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants