Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout override #333

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Fix timeout override #333

merged 2 commits into from
Aug 14, 2019

Conversation

tremby
Copy link

@tremby tremby commented Jan 22, 2019

Closes #332

@codecov-io
Copy link

codecov-io commented Jan 22, 2019

Codecov Report

Merging #333 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   90.39%   90.39%           
=======================================
  Files          43       43           
  Lines        2843     2843           
=======================================
  Hits         2570     2570           
  Misses        273      273
Impacted Files Coverage Δ
django_q/tasks.py 99.46% <ø> (ø) ⬆️
django_q/cluster.py 91.64% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9611423...198ab59. Read the comment docs.

@Koed00
Copy link
Owner

Koed00 commented Jan 27, 2019

Need to check if this doesn't conflict with @jannero 's fixes.
But I'm reviewing all this from my phone. Will run checks when I'm in the office again.

@tremby
Copy link
Author

tremby commented Jan 28, 2019

See #332 for some discussion -- a question has been raised of whether the bug is in the code (if so, this PR fixes it), or in the documentation (in which case this PR is redundant but a documentation change is required).

@Koed00 Koed00 merged commit 198ab59 into Koed00:master Aug 14, 2019
randlet pushed a commit to randlet/django-q that referenced this pull request Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout override is lost when sent to broker
3 participants