Timeout handling fix and improvements to related tests #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old implementation used count_forever test task that never finishes. If the timeout implementation does not work in the test, the test never end and you was required to kill the test runner.
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
==========================================
+ Coverage 90.38% 90.39% +0.01%
==========================================
Files 43 43
Lines 2838 2843 +5
==========================================
+ Hits 2565 2570 +5
Misses 273 273
Continue to review full report at Codecov.
|
… to None (the default) The cluster timeout configuration default value None is documented to mean tasks never timeout out. Also the documentation states that the timeout can be overridden for individual tasks. With the old implementation the timeout parameter given to async_task was not honored if the cluster timeout was set to None. Fixes: Koed00#335
Koed00
approved these changes
Jan 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual fix is in the Fix async_task timeout parameter handling when cluster timeout is set to None (the default)
The other commits improve the related tests