Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduler concurrency with multiple clusters #347

Merged
merged 3 commits into from
Aug 13, 2019
Merged

Fix scheduler concurrency with multiple clusters #347

merged 3 commits into from
Aug 13, 2019

Conversation

maerteijn
Copy link
Contributor

@maerteijn maerteijn commented Mar 13, 2019

This pull request fixes two issues:

@codecov-io
Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #347 into master will not change coverage.
The diff coverage is 94%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #347   +/-   ##
======================================
  Coverage    90.4%   90.4%           
======================================
  Files          43      43           
  Lines        2846    2846           
======================================
  Hits         2573    2573           
  Misses        273     273
Impacted Files Coverage Δ
django_q/cluster.py 91.7% <94%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a6c9d2...958c79e. Read the comment docs.

@randlet
Copy link

randlet commented May 30, 2019

@maerteijn Thanks for prepping this! I think it will make it possible for me to run in e.g. an AWS Auto Scaling group where I have 2-N servers all running qcluster and not have any tasks duplicated is that right? Are you running this in production now?

@maerteijn
Copy link
Contributor Author

@maerteijn Thanks for prepping this! I think it will make it possible for me to run in e.g. an AWS Auto Scaling group where I have 2-N servers all running qcluster and not have any tasks duplicated is that right? Are you running this in production now?

Yes and yes 😃

@randlet
Copy link

randlet commented Jun 3, 2019

@maerteijn Thanks! I experimented a bit with your branch and so far no duplicate tasks while running clusters on 4 separate servers :)

@Koed00
Copy link
Owner

Koed00 commented Aug 10, 2019

Broke this PR by fixing the Arrow issue. If you could change the 'replace' to 'shift' in your code, we should be good.

@maerteijn
Copy link
Contributor Author

Ok, I’ll try to fix this soon(ish)

@maerteijn
Copy link
Contributor Author

I updated the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scheduler creating duplicate tasks in multiple cluster environment
4 participants