Moves unpacking task from Worker to Pusher #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes more sense and gives us more options to work with control queues from the pusher in the future. Does not seem to affect performance.
Koed00
added a commit
that referenced
this pull request
Jul 31, 2015
Moves unpacking task from Worker to Pusher
msabatier
pushed a commit
to msabatier/django-q
that referenced
this pull request
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving the unpacking of task packages to the Pusher process instead of having the Workers handle it, we gain the ability to read task information in the Pusher. This is useful for future development and makes more sense architecturally , cause all process types can now access the same information.
It also seems to improve performance in the load tests marginally.