Preserve database connection when sync=True #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tasks run synchronously django-q should only affect the calling context by running the tasks. Fixes Koed00#326
Codecov Report
@@ Coverage Diff @@
## master #393 +/- ##
==========================================
+ Coverage 90.4% 90.41% +0.01%
==========================================
Files 43 43
Lines 2846 2849 +3
==========================================
+ Hits 2573 2576 +3
Misses 273 273
Continue to review full report at Codecov.
|
|
Is possible to get this fix released? |
Koed00
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tasks run synchronously django-q should only affect the calling
context by running the tasks.
Fixes #326