Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Few cleanup commit for linting and migrations #447

Merged
merged 3 commits into from
Jun 10, 2020

Conversation

Djailla
Copy link
Contributor

@Djailla Djailla commented Jun 10, 2020

  • Remove useless future imports in py3
  • cleanup some lint errors

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2020

Codecov Report

Merging #447 into master will decrease coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
- Coverage   90.80%   90.76%   -0.05%     
==========================================
  Files          44       44              
  Lines        2946     2933      -13     
==========================================
- Hits         2675     2662      -13     
  Misses        271      271              
Impacted Files Coverage Δ
django_q/brokers/aws_sqs.py 0.00% <ø> (ø)
django_q/brokers/ironmq.py 0.00% <0.00%> (ø)
django_q/brokers/orm.py 97.95% <ø> (ø)
django_q/migrations/0001_initial.py 100.00% <ø> (ø)
django_q/migrations/0002_auto_20150630_1624.py 100.00% <ø> (ø)
django_q/migrations/0003_auto_20150708_1326.py 100.00% <ø> (ø)
django_q/migrations/0004_auto_20150710_1043.py 100.00% <ø> (ø)
django_q/migrations/0005_auto_20150718_1506.py 100.00% <ø> (ø)
django_q/migrations/0006_auto_20150805_1817.py 100.00% <ø> (ø)
django_q/migrations/0007_ormq.py 100.00% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 142af91...e356018. Read the comment docs.

@Koed00
Copy link
Owner

Koed00 commented Jun 10, 2020

Thanks 👍 I started the same thing this morning and I'll gladly incorporate this.
Also updating the code with type hinting and some minor other improvements.
Haven't touched most of this in 5 years.

@Koed00 Koed00 merged commit 22dc790 into Koed00:master Jun 10, 2020
@Djailla Djailla deleted the cleanup branch June 10, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants