Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added german translation #499

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Conversation

jonaswinkler
Copy link

@jonaswinkler jonaswinkler commented Jan 15, 2021

This PR adds translation of django-q to German.

Some notes.

  • The .mo files are generated artifacts and should not be added to version control.
  • These files should be generated by django-admin compilemessages when building django-q / making a release.
  • However, since the already existing french translation also included the .mo file despite being ignored in the .gitignore file, I've added this file as well, since not adding that file would require you to adjust release processes.

@Koed00
Copy link
Owner

Koed00 commented Jan 15, 2021

Very cool. Danke vielmals.
Good spot with the .mo files. When I have a little more time in my schedule I'll see about rebuilding the messages when I build releases.

@Koed00 Koed00 merged commit 6f0b24c into Koed00:master Jan 15, 2021
@jonaswinkler
Copy link
Author

jonaswinkler commented Jan 15, 2021

Good spot with the .mo files. When I have a little more time in my schedule I'll see about rebuilding the messages when I build releases.

Well, this is only an issue when you expect your translation files to change frequently, because at some point someone will forget to update that .mo file and the two files will get out of sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants