Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "qmemory" command #553

Merged
merged 5 commits into from
May 14, 2021
Merged

Add "qmemory" command #553

merged 5 commits into from
May 14, 2021

Conversation

kennyhei
Copy link
Contributor

@kennyhei kennyhei commented May 7, 2021

Shows the following info for each cluster:

  • Cluster ID
  • State
  • Uptime
  • Available memory (MB)
  • Available memory (%)
  • Total memory (MB)
  • Memory usage of each worker (MB)

Also tracks lowest available memory (%) with a timestamp. And has the same bottom blue bar info as in qmonitor (Queued/Successful/Failed tasks).

Not exactly sure if all the info is necessary or if I should add something more. I myself was interested in memory related info, uptime, number of queued tasks and which cluster was in question.

@kennyhei
Copy link
Contributor Author

kennyhei commented May 8, 2021

Now that I think about it, I would leave out "State", "Uptime" and that bottom blue bar info (since you can just have a separate terminal with qmonitor on it) and add "Host".

Also maybe sentinel, monitor and pusher memory usage? That would be interesting but I'll wait for feedback.

@Koed00
Copy link
Owner

Koed00 commented May 10, 2021

I agree with you on the bottom blue bar - it would make it a bit more compact.
I would be interested in the sentinel, monitor and pusher memory. Except maybe the pusher, they shouldn't change much over time though.

@kennyhei
Copy link
Contributor Author

Redesigned the qmemory info as follows:

  • Host
  • (Cluster) ID
  • Available memory (%)
  • Available memory (MB)
  • Total memory (MB)
  • Sentinel (MB)
  • Monitor (MB)
  • Workers (MB)

Optional argument --workers shows each worker's memory usage:

  • (Cluster) ID
  • Worker 1 (MB) ... Worker N (MB)

@Koed00
Copy link
Owner

Koed00 commented May 11, 2021

Very nice. Give me a few days before I can actually pull this and have a look again.

@Koed00 Koed00 merged commit 728a1b8 into Koed00:master May 14, 2021
@kennyhei kennyhei deleted the qmemory branch May 15, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants