Allow tasks to be scheduled on a specific cluster #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koed00
approved these changes
May 14, 2021
|
Wish I had more time to review, but first impressions seems to be that this shouldn't affect normal operations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have somewhat of a specific use case. We have multiple Django projects and multiple Django Q clusters sharing the same database.
We needed to be able to specify the cluster on which the task will be scheduled (otherwise the task will scheduled on a cluster with the wrong code base and can't be executed).
I added a "cluster" field to the Schedule model and updated the
schedulefunction as well.When no cluster is specified when the Schedule is created, every clusters can schedule the task (this is the original behaviour).
I also updated the documentation and added a few unit tests. I hope I'm not missing something.