Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RemovedInDjango41Warning #572

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Fix RemovedInDjango41Warning #572

merged 1 commit into from
Jun 9, 2021

Conversation

nurettin
Copy link
Contributor

@nurettin nurettin commented Jun 9, 2021

Fixes

RemovedInDjango41Warning: 'django_q' defines default_app_config = 'django_q.apps.DjangoQConfig'. Django now detects this configuration automatically. You can remove default_app_config.

Fixes 
```
RemovedInDjango41Warning: 'django_q' defines default_app_config = 'django_q.apps.DjangoQConfig'. Django now detects this configuration automatically. You can remove default_app_config.
```
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #572 (7045f55) into master (c47786b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #572   +/-   ##
=======================================
  Coverage   90.22%   90.23%           
=======================================
  Files          50       50           
  Lines        3295     3297    +2     
=======================================
+ Hits         2973     2975    +2     
  Misses        322      322           
Impacted Files Coverage Δ
django_q/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c47786b...7045f55. Read the comment docs.

@nurettin
Copy link
Contributor Author

nurettin commented Jun 9, 2021

Hope this will make it to 1.3.8 and silence our pytests.

@Koed00 Koed00 merged commit 410327b into Koed00:master Jun 9, 2021
@Koed00
Copy link
Owner

Koed00 commented Jun 9, 2021

1.3.8 got released yesterday - but I don't think it will be too long before 1.3.9.

Thanks for addressing the issue and coming up with a fix. It's appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants