-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Trim null characters on spaces when searching for zigbee model. Koenk…
- Loading branch information
Showing
6 changed files
with
282 additions
and
99 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ install: | |
- npm install | ||
|
||
script: | ||
- npm test | ||
- npm run verify | ||
- npm run eslint | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
489a23c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there an actual problem with
@zigbee/zcl-id
?Or is this about equality identity because some other layers of the stack you are using depend on
zcl-id
?In either case, can I suggest you switch back
@zigbee/zcl-id
and change thepackage.json>name
of https://github.com/Koenkk/zcl-id to"@zigbee/zcl-id"
?Then you can still install your version by git commit, but it will mount to the correct place so this back-and-forth can be avoided.
(This is because we don't have access to
zcl-id
npm name, but you are welcome to publish whatever you want under@zigbee
)489a23c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to use the same repo for zigbee2mqtt and zigbee-shepherd-converters.
Once the segmentation fault issue is fixed I will switch zigbee2mqtt and zigbee-shepherd-converters to
@zigbee
489a23c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
I suggest you rename the packages in your forks (
zcl-id
,zcl-packet
,cc-znp
etc) to@zigbee/
, by changing the"name":
inside theirpackage.json
in their repos.This way you can easily switch from your git sources to
@zigbee/
npm sources with a single change topackage.json
(and back in case of problems/wanting to develop a feature on your fork), without changing imports and such.This also makes testing the whole stack locally easier by using
npm link
, without having to use aliases (available in yarn and pnpm, but not npm).Edit: maybe don't rename yet, there is a chance we are getting the original NPM names.