Filter non-realistic WSDCGQ11LM and WSDCGQ01LM temperature reports. K…

…oenkk/zigbee2mqtt#798
Koenkk · Jan 8, 2019 · 74e257f · 74e257f
1 parent 3042d82
commit 74e257f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/converters/fromZigbee.js b/converters/fromZigbee.js
@@ -314,6 +314,20 @@ const converters = {
             return {temperature: precisionRoundOptions(temperature, options, 'temperature')};
         },
     },
+    xiaomi_temperature: {
+        cid: 'msTemperatureMeasurement',
+        type: 'attReport',
+        convert: (model, msg, publish, options) => {
+            const temperature = parseFloat(msg.data.data['measuredValue']) / 100.0;
+
+            // https://github.com/Koenkk/zigbee2mqtt/issues/798
+            // Sometimes the sensor publishes non-realistic vales, as the sensor only works from
+            // -20 till +60, don't produce messages beyond these values.
+            if (temperature > -25 && temperature < 65) {
+                return {temperature: precisionRoundOptions(temperature, options, 'temperature')};
+            }
+        },
+    },
     MFKZQ01LM_action_multistate: {
         cid: 'genMultistateInput',
         type: 'attReport',

diff --git a/devices.js b/devices.js
@@ -202,7 +202,7 @@ const devices = [
         description: 'MiJia temperature & humidity sensor ',
         supports: 'temperature and humidity',
         fromZigbee: [
-            fz.xiaomi_battery_3v, fz.WSDCGQ01LM_WSDCGQ11LM_interval, fz.generic_temperature, fz.xiaomi_humidity,
+            fz.xiaomi_battery_3v, fz.WSDCGQ01LM_WSDCGQ11LM_interval, fz.xiaomi_temperature, fz.xiaomi_humidity,
             fz.ignore_basic_change,
         ],
         toZigbee: [],
@@ -214,7 +214,7 @@ const devices = [
         description: 'Aqara temperature, humidity and pressure sensor',
         supports: 'temperature, humidity and pressure',
         fromZigbee: [
-            fz.xiaomi_battery_3v, fz.generic_temperature, fz.xiaomi_humidity, fz.xiaomi_pressure,
+            fz.xiaomi_battery_3v, fz.xiaomi_temperature, fz.xiaomi_humidity, fz.xiaomi_pressure,
             fz.ignore_basic_change, fz.ignore_temperature_change, fz.ignore_humidity_change,
             fz.ignore_pressure_change, fz.WSDCGQ01LM_WSDCGQ11LM_interval,
         ],