-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Keen Home smart vent #276
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
104c688
- added support for Keen Home smart vent
a893d03
- added more from-zigbee handler for keen vent
095d589
Update devices.js
Koenkk 09a9cac
- updated reporting interval and only handle attReport and ignore dev…
0cc50f9
Merge branch 'master' of github.com:snjoetw/zigbee-shepherd-converters
snjoetw bed25be
- added cover_position handler
c8bd43e
- added cover_position to keen home toZigbee
c345642
Merge branch 'master' of https://github.com/Koenkk/zigbee-shepherd-co…
snjoetw d7846a6
- added transtime to cover_position.set
10ac10d
Update toZigbee.js
Koenkk d3a1f86
Update devices.js
Koenkk dcb5bd9
Merge branch 'master' of https://github.com/Koenkk/zigbee-shepherd-co…
snjoetw 176f7fd
Merge branch 'master' of github.com:snjoetw/zigbee-shepherd-converters
snjoetw a50867d
- added cover_state and cover_position fromZigbee handler
811a74f
Merge branch 'master' of https://github.com/Koenkk/zigbee-shepherd-co…
snjoetw 16d1c5d
- added devChange fromZigbee handler for keen home pressure, temperat…
0246981
- removed reporting config
daab3dd
- fixed lint errors
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 'state' (as homeassistant sends
100
, not{"position": 100}
, when the payload is not JSON,state
will be used as default).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably need more explanation on this ... :)
I was reading this https://www.home-assistant.io/components/cover.mqtt/#set_position_topic
and it sounds like I should use "set_position_topic" instead of "command_topic"
So in this case, I'd think it should be like this?
What I'm also confused about is the 'get' part, I assume it's used by "position_topic"? But as you can see the return value for get is just a command object, how do I convert from brightness to position (0-100) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correction not brightness but currentLevel which is 0-255 based