Add compatibility for 3-Groups RCU from EGLO #5853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Koenkk this is the requested PR for Koenkk/zigbee2mqtt#16890 |
Koenkk
reviewed
Jun 7, 2023
src/devices/awox.ts
Outdated
| @@ -97,6 +104,27 @@ const definitions: Definition[] = [ | |||
| 'green', 'brightness_step_up', 'brightness_step_down', 'brightness_move_up', 'brightness_move_down', 'brightness_stop', | |||
| 'recall_1', 'color_temperature_step_up', 'color_temperature_step_down'])], | |||
| }, | |||
| { | |||
| zigbeeModel: ['ERCU_3groups_Zm'], | |||
| fingerprint: [ | |||
There was a problem hiding this comment.
You can drop the fingerprint (identification goes via zigbeeModel)
There was a problem hiding this comment.
Did so. Hope I did it correctly :)
There was a problem hiding this comment.
But for some reason Github did not update the PR accordingly... I am a bit lost, using GitLab normally :D
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and test compile, I don't know much about TS so might have syntax errors :)