Adding support for diy pcie switch #7873
Open
+48
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you provide a link of a how-to of this device? |
|
lmk if this enough https://github.com/Yuke-hd/zigbee-pcie-switch |
Koenkk
reviewed
Aug 20, 2024
| exposes: [ | ||
| e.binary('status', ea.STATE, true, false).withDescription('Indicates if the PC is powered on (= true) or off (= false)'), | ||
| e.enum('Power', ea.STATE_SET, ['press']).withDescription('Power button').withEndpoint('power'), | ||
| e.enum('Reset', ea.STATE_SET, ['press']).withDescription('Reset button').withEndpoint('reset'), |
There was a problem hiding this comment.
Suggested change
| e.enum('Reset', ea.STATE_SET, ['press']).withDescription('Reset button').withEndpoint('reset'), | |
| e.enum('reset', ea.STATE_SET, ['press']).withDescription('Reset button').withEndpoint('reset'), |
Koenkk
reviewed
Aug 20, 2024
| ], | ||
| exposes: [ | ||
| e.binary('status', ea.STATE, true, false).withDescription('Indicates if the PC is powered on (= true) or off (= false)'), | ||
| e.enum('Power', ea.STATE_SET, ['press']).withDescription('Power button').withEndpoint('power'), |
There was a problem hiding this comment.
Suggested change
| e.enum('Power', ea.STATE_SET, ['press']).withDescription('Power button').withEndpoint('power'), | |
| e.enum('power', ea.STATE_SET, ['press']).withDescription('Power button').withEndpoint('power'), |
Koenkk
reviewed
Aug 20, 2024
| model: 'ESP32C6.PCIE-switch', | ||
| vendor: 'Custom devices (DiY)', | ||
| description: 'PCIE switch', | ||
| fromZigbee: [ |
There was a problem hiding this comment.
Please move the fromZigbee/toZigbee converter to tzLocal/fzLocal (example: https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/devices/adeo.ts#L11)
|
Could you also submit a picture for the docs, also include the link to your github in the
Make sure that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.