Throw error when path doesn't exist.

Koenkk · Oct 16, 2019 · bcb13ad · bcb13ad
1 parent 48bc84d
commit bcb13ad
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/adapter/serialPortUtils.ts b/src/adapter/serialPortUtils.ts
@@ -18,6 +18,10 @@ async function is(path: string, matchers: PortInfoMatch[]): Promise<boolean> {
     const devices = await SerialPort.list();
     // @ts-ignore; not sure why this is needed as path exists (definition is wrong?)
     const device = devices.find((device) => device.path === path);
+    if (!device) {
+        throw new Error(`Path '${path}' does not exist`);
+    }
+
     return matchers.find((matcher) => EqualsPartial(device, matcher)) != null;
 }
 

diff --git a/test/adapter/z-stack/znp.test.ts b/test/adapter/z-stack/znp.test.ts
@@ -128,6 +128,24 @@ describe('ZNP', () => {
         expect(await Znp.isValidPath('/dev/autodetected2')).toBeFalsy();
     });
 
+    it('Check if path is valid; throw error when path does not exist', async () => {
+        mockSerialPortList.mockReturnValue([
+            {manufacturer: 'Not texas instruments', vendorId: '0451', productId: '16a8', path: '/dev/autodetected2'},
+            {path: '/dev/tty.usbmodemL43001T22', manufacturer: 'Texas Instruments', vendorId: '0451', productId: 'bef3'},
+            {path: '/dev/tty.usbmodemL43001T24', manufacturer: 'Texas Instruments', vendorId: '0451', productId: 'bef3'},
+            {path: '/dev/tty.usbmodemL43001T21', manufacturer: 'Texas Instruments', vendorId: '0451', productId: 'bef3'},
+        ])
+
+        let error;
+        try {
+            await Znp.isValidPath('/dev/notexisting')
+        } catch (e) {
+            error  = e;
+        }
+
+        expect(error).toStrictEqual(new Error(`Path '/dev/notexisting' does not exist`));
+    });
+
     it('Open with error', async () => {
         mockSerialPortOpen.mockImplementationOnce((cb) => cb('failed!'));
         mockSerialPortIsOpen = true;