Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ignore): import using node: prefix for built-in #1268

Merged
merged 9 commits into from
Dec 18, 2024

Conversation

Nerivec
Copy link
Collaborator

@Nerivec Nerivec commented Dec 17, 2024

No description provided.

@Koenkk
Copy link
Owner

Koenkk commented Dec 17, 2024

Does it make sense to enable the eslint rule?

Note to self; after this merge Koenkk/zigbee2mqtt#25248

@Nerivec
Copy link
Collaborator Author

Nerivec commented Dec 17, 2024

VSCode kept bugging on this merge conflict for some reason. Looks ok now though.
The rule would be good since it's the expected scheme for the future from what I gather... but it does require the dep (should be an eslint built-in... maybe wait until it is?).

@Koenkk Koenkk merged commit b23e10a into Koenkk:master Dec 18, 2024
1 check passed
@Koenkk
Copy link
Owner

Koenkk commented Dec 18, 2024

thanks!

@Nerivec Nerivec deleted the node-prefix branch December 18, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants